Exposing Zone Sleeps

[jhell]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/26/2010 14:58, Sean Bruno wrote:
> On Wed, 2010-05-26 at 11:52 -0700, Garrett Cooper wrote:
> 
> 
>>>>
>>>> This patch instead pardon the early.post but there was a problem with
>>>> the last patch that I attached for stable/8 r208530 with arguments 10 &
>>>> 11 to function sysctl_vm_zone where it wanted a long unsigned integer
>>>> rather than u_int64_t.
>>>>
>>>> This patch satisfies that. Whether its correct is left to the reader but
>>>> compiles cleanly & runs smoothly.
>>>
>>> I know this seems trivial, but could you change:
>>>
>>> +       printf("%-20s %6s %6s %8s %8s %8s %4s %4s\n\n", "ITEM", "SIZE",
>>> +           "LIMIT", "USED", "FREE", "REQ", "FAIL", "SLEEP");
>>>
>>> to
>>>
>>> +       printf("%-20s %6s %6s %8s %8s %8s %4s %4s\n\n", "ITEM", "SIZE",
>>> +           "LIMIT", "USED", "FREE", "REQS", "FAIL", "SLEEP");
>>>
>>> that way the plural nature of requests is more straightforward and understood.
>>>
>>> Also, do all of the fields _really_ need to have a field width? Seems
>>> like overkill to me...
>>
>> Oh, and the field width for the last item is wrong; SLEEP will be
>> truncated to SLEE.
>> Thanks,
>> -Garrett
> 
> I hate this type of column implementation.  Any ideas on a more useful
> implementation?
> 
> also, I'm missing an email in this thread somehow.  I didn't see the
> second version of the REL-8 patch.
> 
> Sean

Attached is the diff against vmstat.c only *just* to view the
differences. This is also in the sleep_stat_stable8-r208580.diff so no
need to patch twice.

Also attached is the patch for sleep stat on stable/8 "revised". against
r208580:

Changes:
*	Added back the #ifdef DDB
*	vmstat(1) displays all columns in a 80 column display cleanly.

Comments & suggestions ?

I am a little bit shaky about putting the last column so close to the
end of the terminal but that may just be my own personal worries but for
now every field should have enough room to grow as far as I can verify
on my own equipment. Test this out and let me know what you think, if it
wraps or not and whether you think there is enough space for the numbers
to grow in the current layout of the columns.

Thanks again & regards,

- -- 

 jhell
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (FreeBSD)

iQEcBAEBAgAGBQJL/cGqAAoJEJBXh4mJ2FR+oo4IAJWt9sOEhnlmZOG+8Ehf7SKt
QX5ZxBDHz196FR5zOW1p4xjfkGX5ZVD0WytHS7JyTxTiMxkvzELfFpbzfGFtp1U8
Hgtv76gCZnZOEdOTCdtjknJmJNw6FC9FMAXLv5f4tzBj8HNo5sfg0x9wBmEiUfI0
8WO9f83n62lKV5SRyx+jRM/FeAZsNz9zAT0+Z8UmYUDSy+u6jFLYbWD71TzwLMKd
8+Ba/5qsnTTFVfqZOG3lRPcOCdj1QBicRzL+hyKfmNFT1IN8Xek+BhE9sDiOmqK2
0dt87kaDBV5reAeQ1P0Cqvgl7m1JGWg0bJL+c5Z7O2MpcosOxqbfTji1lHQiVZo=
=uA4o
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vmstat-z.diff
Type: text/x-patch
Size: 1091 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-hackers/attachments/20100527/1e3798a9/vmstat-z.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sleep_stat_stable8_r208580.diff
Type: text/x-patch
Size: 8321 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-hackers/attachments/20100527/1e3798a9/sleep_stat_stable8_r208580.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vmstat-z.diff.sig
Type: application/octet-stream
Size: 287 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-hackers/attachments/20100527/1e3798a9/vmstat-z.diff.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sleep_stat_stable8_r208580.diff.sig
Type: application/octet-stream
Size: 287 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-hackers/attachments/20100527/1e3798a9/sleep_stat_stable8_r208580.diff.obj