[patch] somebody please fix this outstanding mmap(2) bug

John Baldwin jhb at freebsd.org
Mon Mar 22 17:41:00 UTC 2010


On Monday 22 March 2010 11:07:43 am Alexander Best wrote:
> could somebody please commit this patch? it's been around forever (2003 or
> 2004) and fixes mmap so the offset argument is being ignored when MAP_ANON 
is
> defined (just like the mmap(2) manual says). right now the offset argument 
is
> being taken into account although MAP_ANON is set!!!
> 
> the pr is kern/71258 (including a little c app to demonstrate the bug)
> 
> i've also sent a followup patch to the pr which returns EINVAL if the offset
> is non zero and MAP_ANON is set, but i guess that might break some code.

I think we should go the EINVAL route, and I will commit the patch you did to 
add that.

-- 
John Baldwin


More information about the freebsd-hackers mailing list