namei() returns EISDIR for "/" (Re: svn commit: r203990 - head/lib/libc/sys)

[Garrett Cooper]

On Thu, Mar 4, 2010 at 9:57 PM, Jaakko Heinonen <jh at freebsd.org> wrote:
> On 2010-02-28, Jaakko Heinonen wrote:
>> > >   http://people.freebsd.org/~jh/patches/lookup-root.diff
>
> I have updated the patch taking some of bde's comments into account. The
> new version also includes updates for namei(9) manual page.
>
> The patch is attached to this mail and also found at:
>
>        http://people.freebsd.org/~jh/patches/lookup-root.2.diff

1. EBUSY's new definition doesn't look correct for rename(2) given
POSIX's definition (
http://www.opengroup.org/onlinepubs/009695399/functions/rename.html ):

[EBUSY]
    [CX] [Option Start] The directory named by old or new is currently
in use by the system or another process, and the implementation
considers this an error. [Option End]

2. I also did some quick snooping around and all filesystems that
support symlinks that FreeBSD has, sans ZFS [*], seem to support
EMLINK. Should we add this to the documentation?

[EMLINK]
    [CX] [Option Start] The file named by old is a directory, and the
link count of the parent directory of new would exceed {LINK_MAX}.
[Option End]

Thanks!
-Garrett

[*] I took a really superficial look at ZFS and this is what I found
(from zfs_pathconf):

        switch (cmd) {
        case _PC_LINK_MAX:
                *valp = INT_MAX;
                return (0);