[PATCH] Fix typos in bsd.port.mk and minor logic improvements

Doug Barton dougb at FreeBSD.org
Mon Jul 12 19:09:46 UTC 2010


On 07/09/10 08:11, Garrett Cooper wrote:
> -# UNAUTHORISED CHANGES WILL BE UNCONDITIONALLY REVERTED!
> +# UNAUTHORIZED CHANGES WILL BE UNCONDITIONALLY REVERTED!

Couple of comments. The above is not a typo, that's the British
spelling. We generally don't change those. (Arguably it adds character
to the project.) :)

The other is more of a question, I'm not sure what the point of these
changes is: ${var:-} The :- parameter substitution kicks in if var is
unset or null, but you're not substituting it with anything.


Doug

-- 

	... and that's just a little bit of history repeating.
			-- Propellerheads

	Improve the effectiveness of your Internet presence with
	a domain name makeover!    http://SupersetSolutions.com/



More information about the freebsd-hackers mailing list