[patch] burncd: honour for envar SPEED

[Giorgos Keramidas]

On Mon, 09 Nov 2009 11:00:43 +0100, Dag-Erling Smørgrav <des at des.no> wrote:
> Giorgos Keramidas <keramida at ceid.upatras.gr> writes:
>> atoi() doesn't really have error checking and it does not necessarily
>> affect `errno'.
>
> man 3 expand_number

I know, but thanks.  In this case, expand_number's logic for parsing
possible SI suffixes is not useful and may be slightly confusing.

I'm not sure what CDROM_SPEED='4m' would mean for burncd's -s option,
for example.

> And please don't call it SPEED or WRITE_SPEED or anything generic; call
> it BURNCD_SPEED or CDROM_BURN_SPEED or something unambiguous.  The envar
> used to specify the device is called CDROM, not DEVICE.

Good point.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-hackers/attachments/20091109/99ddd83a/attachment.pgp