Spot the error

Mel Flynn mel.flynn+fbsd.hackers at mailing.thruhere.net
Wed Aug 5 00:15:51 UTC 2009


On Tuesday 04 August 2009 13:43:24 Dimitry Andric wrote:
> On 2009-08-04 22:45, Mel Flynn wrote:
> > % mount -t msdofs /dev/label/camera ~/camera
> > mount: /dev/label/camera : Operation not supported by device
> >
> > I would expect something along the lines of "unknown file system type".
> > Is this fixable?
>
> Yes, just use "msdosfs" instead. ;)  That said, it looks like ENODEV is
> returned by vfs_domount(), whenever the fs type is not found in the
> list of supported filesystems:
>
> 		[...]
> 		if (fsflags & MNT_ROOTFS)
> 			vfsp = vfs_byname(fstype);
> 		else
> 			vfsp = vfs_byname_kld(fstype, td, &error);
> 		if (vfsp == NULL)
> 			return (ENODEV);
> 		[...]
>
> Note that in the case when vfs_byname_kld() gets called, the error it
> returns is silently thrown away. What a pity. :)
>
> In any case, you could paint a lot of bikesheds about which error code
> from errno.h would be most suited for this situation, unfortunately.

I would expect "Unable to load fs: " + ENOENT. I was asking if this was 
fixable, cause it looked like the code has been abstracted to the point that 
specific errors were hard, but maybe I missed something.
-- 
Mel


More information about the freebsd-hackers mailing list