change to ee.c

Eitan Adler eitanadlerlist at gmail.com
Sat Nov 29 20:22:00 PST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Xin LI wrote:
> Hi, Eitan,

> Tanks for interested in this but I'm afraid that your patch is
> incorrect.  mkstemp returns a file descriptor rather than a string
> pointer, therefore, the subsequent open() would have undefined behavior.
>  It looks like that we actually want fd = mkstemp() here.
Thanks.  If this is the case how come gcc did not return any warnings?
> 
> Note that we may want to bring vendor fixes before making any changes to
> reduce duplicated work...
I was not aware that this was a third party program. I'll look around
and see if this was fixed.

I'm sort of learning C by fixing these minor bugs so any help is
appreciated.
> 
> Cheers,

- --
Eitan Adler
GNU Key fingerptrint: 2E13 BC16 5F54 0FBD 62ED 42B6 B65F 24AB E9C2 CCD1
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (FreeBSD)

iEYEARECAAYFAkkyFNwACgkQtl8kq+nCzNGlRgCeJDMfvnR0ZVtz/k/OjDlrKUUP
3xwAniOJpgueqFh3KVKhk7hS9GFE9fqD
=gTGT
-----END PGP SIGNATURE-----


More information about the freebsd-hackers mailing list