Fwd: [patch] - random(6)

Victor Loureiro Lima victorloureirolima at gmail.com
Mon Jan 8 20:19:41 UTC 2007


I am forwarding this to -hackers, since I havent got any response from
the author (seanc at freebsd.org) in months ;/ Maybe someone in here
could take a few minutes and check this patch out and maybe commit it
to the source tree

att,
victor loureiro lima

---------- Forwarded message ----------
From: Victor Loureiro Lima <victorloureirolima at gmail.com>
Date: 27/11/2006 15:19
Subject: [patch] - random(6)
To: seanc at freebsd.org


Hello Sean,

 My name is Victor, I've sent you a patch which solved the "bug" in
which random(6) would
be way to slow to handle files that are greater than 10MB+, well, I am
re-sending you that
same patch with little modifications, do you think you could include
it in the src tree?
 This patch also increases random(6) performance dramatically even
when working with small-to-medium file sizes, it should be a good
addition to the random(6) source tree, and
its also been extensivelly tested against all features of random(6)
and it scale really well with big files, for example:

--
setuid at zion$ yes | head -200000 > test
setuid at zion$ time ./random -f test > /dev/null
0.257u 0.015s 0:00.27 96.2%     11+14460k 0+0io 0pf+0w
setuid at zion$ time random -f test > /dev/null
187.366u 0.007s 3:07.39 99.9%   10+12945k 0+0io 0pf+0w
--

 And this was on a Intel Core Duo 2 1.8ghz with 1GB of RAM, with one
process taking
less than a second to randomize it all, and the other taking 3
minutes, I think its a good
patch to be applied on the source tree.
 I also took the time to change the man page of random(6) to better
describe the changes,
basically removed the BUGS sections (since that bug is solved by the
patch) and included a new line on the HISTORY section describing my
contribution to the program :).

 Attached are the patches for randomize_fd.c and random.6, also a
little description of the changes made in randomize_fd.c is in the
readme file.
 Hope you find that this is patch is commitable, I would appreciate to
have contributed to FreeBSD even if its just this little contribution
:)

ciao,
victor loureiro lima


More information about the freebsd-hackers mailing list