Some diffs

John Baldwin jhb at freebsd.org
Thu Dec 20 11:55:14 PST 2007


On Thursday 20 December 2007 01:25:11 am M. Warner Losh wrote:
> Consider the following diffs.  The first one does a tiny cleanup of
> strfile's include style (no real reason other than it bugged me when I
> added stdint.h).
> 
> The second one cleans up a minor problem where ${CFLAGS} isn't used
> where it should be.
> 
> The next three cleanup the compilation by not assuming sys/types.h is
> included or by also including <stdint.h>

These all seem fine to me.

> And the last, rather long, patch converts the .y in config to a form
> that more versions of yacc would grok.

I have no yacc-clue.

> Comments?

Was the bsd.prog.mk change accidentally included?

> ==== //depot/projects/arm/src/share/mk/bsd.prog.mk#4 - /Users/imp/p4/arm/src/share/mk/bsd.prog.mk ====
> @@ -110,17 +110,18 @@
>  
>  .if defined(PROG)
>  _EXTRADEPEND:
> -.if defined(LDFLAGS) && !empty(LDFLAGS:M-nostdlib)
> +.if !defined(FOREIGN_BUILD)
>  .if defined(DPADD) && !empty(DPADD)
>  	echo ${PROG}: ${DPADD} >> ${DEPENDFILE}
>  .endif
> -.else
> +.if defined(LDFLAGS) && !empty(LDFLAGS:M-nostdlib)
>  	echo ${PROG}: ${LIBC} ${DPADD} >> ${DEPENDFILE}
>  .if defined(PROG_CXX)
>  	echo ${PROG}: ${LIBSTDCPLUSPLUS} >> ${DEPENDFILE}
>  .endif
>  .endif
>  .endif
> +.endif
>  
>  .if !target(install)

-- 
John Baldwin


More information about the freebsd-hackers mailing list