kern/104436: [PATCH] sys/sem.h should include sys/types.h
Bruce Evans
bde at zeta.org.au
Sun Oct 15 08:22:22 PDT 2006
On Sun, 15 Oct 2006, Cheng-Lung Sung wrote:
> System: FreeBSD.csie.nctu.edu.tw 6.1-STABLE FreeBSD 6.1-STABLE #9: Thu May 11 14:31:45 CST 2006 root at FreeBSD.csie.nctu.edu.tw:/home/usr.obj/usr/src/sys/FREEBSD i386
>
>> Description:
> - sys/sem.h has included sys/ipc.h, which includes sys/_types.h
> but it (and its including files) does not include sys/types.h
> - therefore, in sys/sem.h struct semid_ds declares "time_t sem_otime;" ...etc
> - if we only compile a program which do not include sys/types.h, it will fail.
Including sys/types.h would add lots of namespace pollution which
sys/ipc.h and sys/sem.h are trying hard to avoid. sem.h is trying too
hard -- POSIX requires it to declare time_t (and pid_t, key_t and size_t,
which it already declares).
Bruce
More information about the freebsd-hackers
mailing list