pfctl

[Earl Lapus]

hi,

I was browsing through some code and stumbled upon this:

...
if ((opts->rtsc_m1 < opts->rtsc_m2 && opts->rtsc_m1 != 0) ||
   (opts->rtsc_m1 < opts->rtsc_m2 && opts->rtsc_m1 != 0) ||
   (opts->rtsc_m1 < opts->rtsc_m2 && opts->rtsc_m1 != 0)) {
   warnx("m1 must be zero for convex curve: %s", pa->qname);
   return (-1);
}
...


would it be safe to change it to:
...
if (opts->rtsc_m1 < opts->rtsc_m2 && opts->rtsc_m1 != 0) {
   warnx("m1 must be zero for convex curve: %s", pa->qname);
   return (-1);
}
...

-OR- is there something between those lines that I'm missing.

The piece of code that I'm referring to is found in
/usr/src/contrtib/pf/pfctl/pfctl_altq.c





-- 
There are seven words in this sentence.