m_free() in if_bridge

[Ruslan Ermilov]

On Wed, Nov 08, 2006 at 04:37:34PM +0200, Jacques Fourie wrote:
> While browsing through if_bridge.c I noticed that if the bridge
> interface is in monitoring mode, m_free() gets called on the packet
> after passing it to BPF. Should this not be m_freem() instead or am I
> missing something?  The code in question can be found in the
> bridge_input() function, line 1877 in if_bridge.c.
> 
It's been fixed already:

: revision 1.85
: date: 2006/11/05 17:56:25;  author: csjp;  state: Exp;  lines: +1 -1
: Fix possible leak when bridge is in monitor mode. Use m_freem() which will
: free the entire chain, instead of using m_free() which will free just the
: mbuf that was passed.
: 
: Discussed with: thompsa
: MFC after:      3 days


Cheers,
-- 
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-hackers/attachments/20061108/a08b2ffc/attachment.pgp