[PATCH] add header "pppoe:" in ng_pppoe.c printfs
glebius at FreeBSD.org
Fri Aug 4 18:21:28 UTC 2006
On Fri, Aug 04, 2006 at 04:48:49PM +0100, Joao Barros wrote:
J> On 8/4/06, Gleb Smirnoff <glebius at freebsd.org> wrote:
J> >On Thu, Aug 03, 2006 at 03:35:04PM +0100, Joao Barros wrote:
J> >J> Being this a cryptic message to say the least and to probably save
J> >J> someone some time when presented with this message I attach a patch
J> >J> that adds the header "pppoe:" in every printf that didn't have it,
J> >J> making it consistent with the rest of the file.
J> >I've attached a patch that cleans a bit logging in ng_pppoe. It changes
J> >all printf(9) to log(9). The latter is better since it spams console
J> >less, if event occurs many times per second. Also I've made the messages
J> >more clear - prepended node ID where possible, function name when it
J> >starts with ng_pppoe, or just "ng_pppoe".
J> >Can you please try out this patch and tell whether you like it. If you
J> >do I will commit it soon.
J> I've looked at the patch and it looks ok.
J> It serves the purpose: make the messages more clear with the added
J> bonus of more info.
J> Thanks for taking the time to look into this :-)
Since I don't use ng_pppoe now much, I'd appreciate if you
do at brief test of this patch, before I commit it.
Totus tuus, Glebius.
More information about the freebsd-hackers