Oddity in libufs.
Giorgos Keramidas
keramida at linux.gr
Sun Sep 25 04:01:01 PDT 2005
On 2005-09-24 20:26, Frank Mayhar <frank at exit.com> wrote:
> I've been using libufs as the I/O mechanism for my (heavy) modification
> of sysutils/ffsrecov. It's working to my needs and now I'm poking at
> other bits and pieces to maybe get it suitable for release into the
> wild. I just looked at cgread() to see what it does and noticed that
> there seems to be a redundant line:
>
> .
> .
> if (c >= fs->fs_ncg) {
> return (0);
> }
> ccg = fsbtodb(fs, cgtod(fs, c)) * disk->d_bsize;
> if (bread(disk, fsbtodb(fs, cgtod(fs, c)), disk->d_cgunion.d_buf,
> .
> .
>
> That assignment up there looks redundant, as ccg is never used. I
> suspect that it's a relic of an old lseek()/read() pair that's long
> gone.
It's probably easy to verify that without this assignment 'ccg' is an
unused var:
- Comment it out
- Rebuild with an elevated WARNS level
if a warning about 'unused ccg var' is printed, then you are certain
that ccg was only used for the assignment.
More information about the freebsd-hackers
mailing list