portmanager

Sergey Matveychuk sem at FreeBSD.org
Thu Oct 13 04:37:51 PDT 2005


Michael C. Shultz wrote:
> 
> if ( getenv("TERM") )
> {
> 	. . .
> }

Anyway you should use code like that for the cases:
char *term;
term = getenv("TERM");

And check the variable afterwards. It much better than call getenv() twice.
And the first condition would be:
if( term && !strncmp( term, "xterm", 5 ) && isatty(fileno(stdout)) )

And some people not recomend use '!' with str[n]cmp(). Using '== 0' is 
better.

It was someting about a code style.

-- 
Sem.


More information about the freebsd-hackers mailing list