ip_reass() - possibly incorrect goto

Vijay.Singh at nokia.com Vijay.Singh at nokia.com
Tue Mar 22 12:10:55 PST 2005


Hi hackers, I am looking at the ip_reass() routine. In case of the 1st fragment we create the reassembly queue. After the queue has been inserted in the hash bucket, the if () code does a " goto inserted". Should this be changed to "goto done" instead? Any code that is executed for the 1st fragment, like frag per packet limiting and complete reassembly are not valid. Am I mistaken?

br
vijay


More information about the freebsd-hackers mailing list