Small bug fix from DragonFly / review requested

Max Laier max at love2party.net
Sun Feb 20 10:36:34 PST 2005


Joerg Sonnenberger has discovered a problem in the snc(4) driver that might 
result in packets showing up on bpf multiple times.  See the changelog for 
sys/dev/netif/snc/dp83932.c in their source tree[1].

Attached is a fix for HEAD.  I am almost sure that it is right, but I'd 
welcome a review as there might be a chance that sonicput() and the TX 
interrupt free the mbuf before it gets to bpf.  From my reading it seems that 
the mbuf is "safe" until sc->mtd_free is altered (see comment).

Thanks for your input.

[1] http://www.dragonflybsd.org/cvsweb/src/sys/dev/netif/snc/dp83932.c

-- 
/"\  Best regards,                      | mlaier at freebsd.org
\ /  Max Laier                          | ICQ #67774661
 X   http://pf4freebsd.love2party.net/  | mlaier at EFnet
/ \  ASCII Ribbon Campaign              | Against HTML Mail and News
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dp83932.c.diff
Type: text/x-diff
Size: 976 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-hackers/attachments/20050220/5c831492/dp83932.c.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-hackers/attachments/20050220/5c831492/attachment.bin


More information about the freebsd-hackers mailing list