[patch] rc.d cleanup

[Brooks Davis]

On Mon, Aug 01, 2005 at 09:47:54PM -0500, diz at linuxpowered.com wrote:
> > diz at linuxpowered.com wrote this message on Mon, Aug 01, 2005 at 12:29
> > -0500:
> >> This has the result of reducing the size of the shell code, and reducing
> >
> > Unless you cross a fs frag (usually 1024 bytes), i.e. reduce the scripts
> > by an average of 512bytes *per* script, you will see no disk space savings
> > from these changes...  considering that on my 5.4-R system over half
> > (73 of 124) are under a frag in size, it isn't that much...
> >
> > One thing that would be really useful for rc.d system is a way to cache
> > the ordering on boot...  On a slow system like a 200mhz arm, the rc
> > ordering can take a long while....
> >
> > --
> >   John-Mark Gurney				Voice: +1 415 225 5579
> >
> >      "All that I will do, has been done, All that I have, has not."
> >
> 
> 
> Ok thanks for the dirrection. Ask and thy shall receive. well a quick hack
> at least to implement cache of rcorder, although from my tests even on old
> hardware rcorder is quick. I wrote this in (cring) the long-spelled out
> way. Anyways... don't forget to add the essential rc.conf knobs for the
> two variables shown bellow.
> 
> [root@:/etc]# diff -u rc rc.new
> --- rc  Sun Jul 31 17:45:19 2005
> +++ rc.new      Mon Aug  1 21:42:12 2005
> @@ -72,7 +72,17 @@
> 
>  skip="-s nostart"
>  [ `/sbin/sysctl -n security.jail.jailed` -eq 1 ] && skip="$skip -s nojail"
> -files=`rcorder ${skip} /etc/rc.d/* 2>/dev/null`
> +# check for a rc.conf knob to check for existing cache, and skip the
> rcorder part
> +if checkyesno ${rc_cache_enable} ; then
> +       if [ -f ${rc_cache_file} ] ; then
> +               files=`cat ${rc_cache_file}`
> +       else
> +               files=`rcorder ${skip} /etc/rc.d/* 2>/dev/null`
> +               echo "${files}" > ${rc_cache_file}
> +       fi
> +else
> +       files=`rcorder ${skip} /etc/rc.d/* 2>/dev/null`
> +fi
> 
>  for _rc_elem in ${files}; do
>         run_rc_script ${_rc_elem} ${_boot}

I'm pretty sure you don't have access to the contents of /etc/rc.conf in
this context.  You would have to use another mechanism to control this
feature.  I'd be tempted to use the existance of a cache file (probably
/etc/rcorder.cache since it can't be outside /) and simply require users
to regenerate it externally when they upgrade (I'd probably add code to
mergemaster to handle it like the various database files).  Note that we
may well break the ability to do this is easily in 7.0 if we end up
supporting ordering of local scripts.

-- Brooks

-- 
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-hackers/attachments/20050801/7bd0a230/attachment.bin