[PATCH] Re: Linksys PCM200

[soralx at cydem.org]

> If you have done any testing, that should be sufficent.

I've done a little testing under various loads. The driver switches
chip to store and forward mode soon during initial use after attaching
(I also get few messages about watchdog timeouts together with 
"increasing TX threshold"). But it seems to work OK.
I haven't done any serious performance testing (maximum speed it
could reach was ~ 5Mb/s on 100baseTX/FD) nor attach/detach tests.

> After all, the
> hardware didn't work before, right?

yes, it wasn't recognized before

> It did work before that's another
> issue, but if not, all that matters is that we don't break any other
> cards.

I don't see a way how it could break other cards' functionality - should
be no concerns here

> > I suggest that you change the description to:
> > "Linksys PCM200 EtherFast 10/100 CardBus NIC, v.03 (ADMtek Centaur-C)"
> >
> > Card's versions differ between each other significantly. Also, there will
> > be no easy way to find out card's chipset if it won't be stated in the
> > description.
> > The string will fit on console even better:
> >
> > dc0: <Linksys PCM200 EtherFast 10/100 CardBus NIC, v.03 (ADMtek
> > Centaur-C)> port 0x1000-0x10ff mem 0x88002000-0x880023ff irq 9 at device
> > 0.0 on cardbus1
>
> I disagree.  If you need that level fo detail, you should use pciconf
> -lv.

I don't see a real reson not to use more complete description. There are
few resons to use it:

0. More info is _always_ better. In any case, the message will take 2 lines
on console, so shortening the description will not gain anything
1. the description in `pciconf -lv` does not show card's version and chipset
2. when PCI IDs for previous card versions will be added, the description will
need to be changed anyway to include the version number

Timestamp: 0x417A853C
[SorAlx]  http://cydem.org.ua/
ridin' VN1500-B2