About rules on style changes [Was: Re: Preliminary sys/netinet style patch]

[Xin LI]

Hi, Dag-Erling,

(I have removed freebsd-net@ from cc list and added doc@ as the topic
seemed to be more related to doc@)

On Tue, Jul 06, 2004 at 01:50:34PM +0200, Dag-Erling Sm?rgrav wrote:
> Xin LI <delphij at frontfree.net> writes:
> > I have a patchset to remove tailing spaces, convert leading spaces
> > to tabs, and removes spaces before tabs.
> 
> As a rule, we never do this except in conjunction with other changes.

Hmm... Seems that I have misunderstood the committers' guide, section
10.3, which said:

"Do not mix style fixes with new functionality. A style fix is any
change which does not modify the functionality of the code. Mixing the
changes obfuscates the functionality change when using cvs diff, which
can hide any new bugs."

I thought that this is not a strict discourage of style fixes. Shall
we add something to clarify the rule, like this:

"In order to prevent difficulties other committers will encounter when
making changes or merging changes from third party, it is discouraged
to do style changes when there is no functional changes over a subsystem,
and please follow style(9) when committing new code, as a consistent
style will ease others' work when merging your changes."

Thanks.

Cheers,
-- 
Xin LI <delphij frontfree net>	http://www.delphij.net/
See complete headers for GPG key and other information.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-hackers/attachments/20040706/d1ad084e/attachment.bin