diskless problems

Danny Braniss danny at cs.huji.ac.il
Mon Jan 12 03:23:18 PST 2004


i re-applied the patches to the latest bootp.c, and took care not to
botch up the tabs, but my user friendly emacs was not too helpful :-)
(the diff is now about 500 lines)
the PR is:
	http://www.freebsd.org/cgi/query-pr.cgi?pr=61239
thanks,
	danny

> Sounds very interesting indeed.  Could you:
> 
> (1) Update it to bootp.c:1.5; this just removed 'register', and it looks
>     like you've already done that.
> 
> (2) Restore the original file style -- right now, it's a very hard to read
>     diff because you use different tabbing, function prototypes, etc, so
>     it's hard to isolate and read the changes.  There's probably some room
>     for style convergence (new function prototypes), but we have a
>     long-standing tradition of committing style and functional chaanges
>     separately so cvs diff is maximally useful between revisions.  It
>     looks like the main difference is that you use four space tabs, and
>     the original file uses real tab characters. 
> 
> Then if you could file a PR and drop me the PR number by e-mail, that
> would be great.  I can do the style stuff if necessary, but I figured
> since you're much more familiar with the changes, it might not be a bad
> idea if you did it :-).
> 
> Robert N M Watson             FreeBSD Core Team, TrustedBSD Projects
> robert at fledge.watson.org      Senior Research Scientist, McAfee Research
> 




More information about the freebsd-hackers mailing list