maintainer-approval requested: [Bug 245156] audio/pulseaudio: parse /dev/sndstat correctly to get device name : [Attachment 213026] Proposed patch (since 516738 revision, v3)

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Fri Apr 3 18:26:40 UTC 2020


lightside <lightside at gmx.com> has asked freebsd-gnome mailing list
<gnome at FreeBSD.org> for maintainer-approval:
Bug 245156: audio/pulseaudio: parse /dev/sndstat correctly to get device name
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245156

Attachment 213026: Proposed patch (since 516738 revision, v3)
https://bugs.freebsd.org/bugzilla/attachment.cgi?id=213026&action=edit



--- Comment #16 from lightside <lightside at gmx.com> ---
Created attachment 213026
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=213026&action=edit
Proposed patch (since 516738 revision, v3)

Attached patch for third variant, based on comment #15 and Greg V proposal on:
https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/commit/94a781060e64cb871
c0f2d3ee768123dd904f0a8?merge_request_iid=277

I also modified output format, based on Henry Hu proposal in attachment
#212838, i.e.
from "pa_snprintf(name, l, "%d - %s", device, k);" to "pa_snprintf(name, l,
"%d: %s", device, k);". But I guess, developers may decide about what to use in
this case.

Thanks for attention.


More information about the freebsd-gnome mailing list