maintainer-feedback requested: [Bug 214468] devel/glib20 return error in gmesssage.h

[bugzilla-noreply at freebsd.org]

w.schwarzenfeld at utanet.at has reassigned Bugzilla Automation
<bugzilla at FreeBSD.org>'s request for maintainer-feedback to gnome at FreeBSD.org:
Bug 214468: devel/glib20 return error in gmesssage.h
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=214468



--- Description ---
I tried to reinstall lxterminal.

It failed with:
setting.c:165:5: error: non-void function 'copy_setting' should return a value
[-Wreturn-type]
    g_return_if_fail (setting != NULL);
    ^
/usr/local/include/glib-2.0/glib/gmessages.h:373:3: note: expanded from macro
'g_return_if_fail'
	 return;							\
	 ^
1 error generated.

the error is in /usr/local/include/glib-2.0/glib/gmessages.h:
line 374
#define g_return_if_fail(expr)		G_STMT_START{			\
     if G_LIKELY(expr) { } else 					\
       {								\
	 g_return_if_fail_warning (G_LOG_DOMAIN,			\
				   G_STRFUNC,				\
				   #expr);				\
=>	   return;							  \
       };	  

and the same in lin 392.

If I set return 1 I got a lot more errors.

So I deleted it. But this is surely wrong. g_return_if_fails must return
something.