[Bug 193625] www/webkit-gtk3: Update to 2.4.4, Make NLS and HTML docs conditional for multiple ports

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193625

Kubilay Kocak <koobs at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |needs-patch, needs-qa
             Status|Needs Triage                |Open
           Assignee|freebsd-ports-bugs at FreeBSD. |gnome at FreeBSD.org
                   |org                         |
            Summary|[change-request]            |www/webkit-gtk3: Update to
                   |webkit-gtk3 updated to      |2.4.4, Make NLS and HTML
                   |2.4.4; non-mandatory NLS    |docs conditional for
                   |and HTML docs for some      |multiple ports
                   |ports                       |

--- Comment #5 from Kubilay Kocak <koobs at FreeBSD.org> ---
Thanks for your submission Mike!

Each port has a different maintainer, and several ports are affected (changed)
by your patches. Each of them will need maintainer approval, so we need to do
one of the following:

1) Attach each port patch as an individual and separate attachment in this
issue (with a super obvious name like "category/portname" or something similar.

OR

2) Create a new issue report for each port

The downside of (1) is that we need to obtain approval for each one to consider
this issue resolved, and all of them will need to committed together (even they
don't need to be).

The downside of (2) is additional overhead for you and our bug
tracking/triaging team. 

My personal preference is for (1), so can you:

- Remove the tarball attached here
- Attach each of the port patches as a separate attachment. (with .diff or
.patch extension)

Additionally, you probably also want to use the new OPTIONS HELPER syntax
everywhere you can, instead of:

.if (${PORT_OPTIONS:MFOO}
  blah
.else
  blah
.endif

See: Mk/bsd.options.mk, just under the following comment:

# The following knobs are there to simplify the handling of OPTIONS in simple
# cases :

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.