[patch] improvements to www/webkit-gtk2 port

Guido Falsi mad at madpilot.net
Mon Jul 21 11:01:24 UTC 2014


On 07/21/14 12:47, Alexey Dokuchaev wrote:
> hi there,
> 
> please consider attached patch (this is the first draft; ideally i want to
> fix both webkit-gtk{2,3} ports at once since they are very similar; maybe
> even turning them into master/slave pair).
> 
>   - Dependency on devel/gperf from ports seems a leftover from the old days;
>     today both base and ports offer version 3.0.3 (the latest GPLv2 one)
>   - Dependency on textproc/gtk-doc looks bogus; removing and passing option
>     --disable-gtk-doc (just in case) makes no observable changes in the
>     resulting package (no pkg-plist changes unless I'm missing something),
>     so I propose we just remove it (at it pulls some not very nice shit)
>   - Use some convenient option helpers (and CFLAGS_powerpc64)
>   - Remove WEBGL_DESC, it's in the default descriptions pool now
>   - Allow it to be built without GStreamer (but enable it by default)
>   - Correctly detect Clang via USE=compiler and adjust COMMENT while here
> 
> tinderbuilds went OK, but of course more review/testing is welcome!
> 

Just something I noticed reding the patch:

+USES=		bison compiler gettext gmake perl5 pkgconfig tar:xz
+USE_AUTOTOOLS=	libtool

I think this should be

USES=		bison compiler gettext gmake libtool perl5 pkgconfig tar:xz
USE_AUTOTOOLS=	libtoolize

-- 
Guido Falsi <mad at madpilot.net>


More information about the freebsd-gnome mailing list