[patch] devel/libgsf: make GCONF really OPTIONal

Jeremy Messenger mezz.freebsd at gmail.com
Sun Feb 24 23:05:16 UTC 2013


On Fri, Feb 22, 2013 at 10:20 PM, Alexey Dokuchaev <danfe at nsu.ru> wrote:
> On Fri, Feb 22, 2013 at 12:46:53PM -0600, Jeremy Messenger wrote:
>> On Fri, Feb 22, 2013 at 10:35 AM, Alexey Dokuchaev <danfe at nsu.ru> wrote:
>> > hi there,
>> >
>> > it's a bit inconvenient to manually specify WITHOUT_GCONF every time i
>> > build devel/libgsf.  mind if i commit attached patch?
>>
>> We can't use OPTIONS with the auto check dependency. It breaks the
>> user usability, IMO.  I can't access to the FreeBSD for a few weeks,
>> so can you check to see if there is flag in its configure to disable
>> gconf? If it does then remove that auto check and add the disable flag
>> then you can commit it. Thanks!
>
> Yes, there is a --without-gconf switch, and it works as advertised.  I've
> also removed PLIST_SUB magic, as it seems a bit excessive for just one
> file, and used PLIST_FILES instead.  New diff is attached.

I am no fan of PLIST_FILES and plist dynamic because both cripple my
search for file in pkg-plist. But I don't really care at some point,
so you can go ahead commit it. Thanks!

> ./danfe


-- 
mezz.freebsd at gmail.com - mezz at FreeBSD.org
FreeBSD GNOME Team
http://www.FreeBSD.org/gnome/ - gnome at FreeBSD.org


More information about the freebsd-gnome mailing list