gnome-terminal Bug 646317

[Cy Schubert]

In message <CADLFttftadJg+hX+Aa16iABSmmXRjt9DutYecNTAHnuVEx1t6g at mail.gmail.c
om>
, Jeremy Messenger writes:
> On Fri, Mar 23, 2012 at 11:20 PM, Cy Schubert <Cy.Schubert at komquats.com> wrot
> e:
> > Gnome bugzilla bug 646317 (https://bugzilla.gnome.org/show_bug.cgi?id=64631
> 7
> > ) addresses a bug in gnome-terminal in which it returns an invalid exit
> > status causing some environments (e.g. e17) to complain
> > (http://trac.enlightenment.org/e/ticket/823). Would anyone mind if I
> > committed the following patch, obtained from https://bugzilla.gnome.org/sho
> w
> > _bug.cgi?id=646317,  to gnome-terminal?
> 
> You can go ahead commit it. Thanks!
> 
> Cheers,
> Mezz

Thanks. Committed.

~cy

> 
> 
> > Index: Makefile
> > ===================================================================
> > RCS file: /home/pcvs/ports/x11/gnome-terminal/Makefile,v
> > retrieving revision 1.72
> > diff -u -r1.72 Makefile
> > --- Makefile    23 Sep 2011 22:26:11 -0000      1.72
> > +++ Makefile    24 Mar 2012 04:12:38 -0000
> > @@ -8,6 +8,7 @@
> >
> >  PORTNAME=      gnome-terminal
> >  PORTVERSION=   2.32.1
> > +PORTREVISION=  1
> >  CATEGORIES=    x11 gnome
> >  MASTER_SITES=  GNOME
> >  DIST_SUBDIR=   gnome2
> > Index: files/patch-src-terminal.c
> > ===================================================================
> > RCS file: files/patch-src-terminal.c
> > diff -N files/patch-src-terminal.c
> > --- /dev/null   1 Jan 1970 00:00:00 -0000
> > +++ files/patch-src-terminal.c  24 Mar 2012 04:12:38 -0000
> > @@ -0,0 +1,11 @@
> > +--- src/terminal.c.orig        2010-11-10 10:47:14.000000000 -0800
> > ++++ src/terminal.c     2012-03-23 21:10:08.520503912 -0700
> > +@@ -579,7 +579,7 @@
> > +     data = g_new (OwnData, 1);
> > +     data->factory_name = get_factory_name_for_display (display_name);
> > +     data->options = options;
> > +-    data->exit_code = -1;
> > ++    data->exit_code = EXIT_SUCCESS;
> > +     data->argv = argv_copy;
> > +     data->argc = argc_copy;
> > +
> >
> >
> >
> > --
> > Cheers,
> > Cy Schubert <Cy.Schubert at komquats.com>
> > FreeBSD UNIX:  <cy at FreeBSD.org>   Web:  http://www.FreeBSD.org
> >
> >        The need of the many outweighs the greed of the few.
> >
> >
> > _______________________________________________
> > freebsd-gnome at freebsd.org mailing list
> > http://lists.freebsd.org/mailman/listinfo/freebsd-gnome
> > To unsubscribe, send any mail to "freebsd-gnome-unsubscribe at freebsd.org"
> 
> 
> 
> -- 
> mezz.freebsd at gmail.com - mezz at FreeBSD.org
> FreeBSD GNOME Team
> http://www.FreeBSD.org/gnome/ - gnome at FreeBSD.org
> 
> 


-- 
Cheers,
Cy Schubert <Cy.Schubert at komquats.com>
FreeBSD UNIX:  <cy at FreeBSD.org>   Web:  http://www.FreeBSD.org