R: [PATCH] sysutils/gnome-settings-daemon: depend on libgdbm

[Barbara]

>>Submitter-Id:	current-users
>>Originator:	Jimmy Olgeni
>>Organization:	
>>Confidential:	no 
>>Synopsis:	[PATCH] sysutils/gnome-settings-daemon: depend on libgdbm
>>Severity:	non-critical
>>Priority:	low
>>Category:	ports 
>>Class:		change-request
>>Release:	FreeBSD 8.2-STABLE amd64
>>Environment:
>System: FreeBSD backoffice 8.2-STABLE FreeBSD 8.2-STABLE #1: Sun May 15 20:37:
17 CEST 2011
>>Description:
>This port needs to depend on databases/gdbm because it links directly
>with libgdbm (libmedia-keys.so).
>
>(portlint complained about CPPFLAGS being included in CONFIGURE_ENV
>but I left it alone)
>
>Port maintainer (gnome at FreeBSD.org) is cc'd.
>
>Generated with FreeBSD Port Tools 0.99
>>How-To-Repeat:
>>Fix:
>
>--- gnome-settings-daemon-2.32.1_3.patch begins here ---
>Index: Makefile
>===================================================================
>RCS file: /home/pcvs/ports/sysutils/gnome-settings-daemon/Makefile,v
>retrieving revision 1.22
>diff -u -u -r1.22 Makefile
>--- Makefile	23 Aug 2011 18:39:13 -0000	1.22
>+++ Makefile	13 Sep 2011 11:39:52 -0000
>@@ -8,7 +8,7 @@
> 
> PORTNAME=	gnome-settings-daemon
> PORTVERSION=	2.32.1
>-PORTREVISION=	2
>+PORTREVISION=	3
> CATEGORIES=	sysutils gnome
> MASTER_SITES=	GNOME
> DIST_SUBDIR=	gnome2
>@@ -18,7 +18,8 @@
> 
> LIB_DEPENDS=	canberra-gtk.0:${PORTSDIR}/audio/libcanberra \
> 		notify.4:${PORTSDIR}/devel/libnotify \
>-		nss3.1:${PORTSDIR}/security/nss
>+		nss3.1:${PORTSDIR}/security/nss \
>+		gdbm.4:${PORTSDIR}/databases/gdbm
> RUN_DEPENDS=	xrdb:${PORTSDIR}/x11/xrdb
> 
> CONFLICTS=	gnome-settings-daemon-3.[0-9]*
>--- gnome-settings-daemon-2.32.1_3.patch ends here ---
>

As I wrote in a previous message in the gnome ml, libmedia-keys.so should be 
built only if gsd is built with PULSEAUDIO, so maybe the entry for LIB_DEPENDS 
could be moved below (=+), in the "else" of the test for WITHOUT_PULSEAUDIO.