ruby-gnome update for review

Wesley Shields wxs at FreeBSD.org
Sat Sep 11 13:03:30 UTC 2010


On Sat, Sep 11, 2010 at 01:36:11PM +0200, Koop Mast wrote:
> On Tue, 2010-09-07 at 21:21 -0400, Steve Wills wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> > 
> > Hi,
> > 
> > Please see this patch which attempts to update the ruby-gnome ports:
> > 
> > http://people.freebsd.org/~swills/ruby_gnome_update_patch.txt
> 
> Looking good, don't forget to reset PORTREVISION's :)

Agreed. Since you are bumping PORTVERSION on these you should reset
PORTREVISION. No need to resubmit a patch for approval for that,
consider it approved provided you do that.

> > 
> > I've run test builds on 8.1 and 7.4. The logs can be found here:
> > 
> > http://people.freebsd.org/~swills/FreeBSD/logs/
> > 
> > I've done run time testing using "erubychess" (not in ports):
> > 
> > http://rubyforge.org/projects/erubychess/
> > 
> > Proposed commit message:
> > - ---------------------
> > - - Update ruby-gnome ports to 0.19.4
> > 
> > Approved by:	gnome@, X (mentor)
> > - ---------------------
> 
> I think this is beter, since gnome@ doesn't maintain these ports.
> 
> - ---------------------
> Approved by:	X (mentor)
> Reviewed by:	kwm (gnome@)
> - ---------------------

Agreed here too. Thanks Koop for the review!

-- WXS


More information about the freebsd-gnome mailing list