[patch] converters/fribidi fails to build if devel/glib20 is installed

[John Hein]

>Submitter-Id:	current-users
>Originator:	John Hein
>Organization:
>Confidential:	no <FreeBSD PRs are public data>
>Synopsis:	[patch] converters/fribidi fails to build if devel/glib20 is installed
>Severity:	non-critical
>Priority:	low
>Category:	ports
>Class:		sw-bug
>Release:
>Environment:

FreeBSD 7-STABLE

>Description:

--with-glib=auto is the default 'configure' behavior.  But 0.19.2
fails to link if glib is detected at the time configure is run:

../lib/.libs/libfribidi.so: undefined reference to `g_assert'

The reason is that g_assert is not defined because 
glib/gtestutils.h is not included.

This was noticed with glib-2.24.2, but likely occurs
with other versions of glib, too.

It was fixed in cvs upstream ...
http://lists.freedesktop.org/archives/fribidi/2010-February/000598.html

... but no new release has been made.

For 0.19.2 in ports, just use --without-glib (which is effectively
how pointyhat builds it since glib is not a dependency).

The patch below does that.  It also fixes the URL in pkg-descr.


>How-To-Repeat:

Install devel/glib20.
Then try to build converters/fribidi.

>Fix:

-------------- next part --------------
Index: Makefile
===================================================================
RCS file: /base/FreeBSD-CVS/ports/converters/fribidi/Makefile,v
retrieving revision 1.22
diff -u -p -r1.22 Makefile
--- Makefile	23 Aug 2009 17:17:33 -0000	1.22
+++ Makefile	3 Oct 2010 01:18:30 -0000
@@ -42,6 +42,8 @@ MAN3=		fribidi_charset_to_unicode.3 frib
 CONFIGURE_ARGS=	--disable-debug
 .endif
 
+CONFIGURE_ARGS+=	--without-glib
+
 post-patch:
 	@${SED} -e 's|%%LOCALBASE%%|${LOCALBASE}|g' < \
 	    	${FILESDIR}/fribidi-config > ${WRKDIR}/fribidi-config
Index: pkg-descr
===================================================================
RCS file: /base/FreeBSD-CVS/ports/converters/fribidi/pkg-descr,v
retrieving revision 1.3
diff -u -p -r1.3 pkg-descr
--- pkg-descr	12 Sep 2005 07:29:08 -0000	1.3
+++ pkg-descr	3 Oct 2010 01:23:56 -0000
@@ -17,4 +17,4 @@ every Unicode character will be treated 
 specification. The same is true for the mirroring of characters, which also
 works for all the characters listed as mirrorable in the Unicode specification.
 
-WWW: http://fribidi.org/wiki/
+WWW: http://fribidi.org/