[Patch] Build libiconv with USE_CSTD=gnu89

[Ed Schouten]

Hi all,

Pav just added support to the Ports tree to easily specify the C
standard in the port makefiles. Even though the compiler in our base
system uses -std=gnu89 by default, this behaviour could change in the
future. Other compilers (like Clang) already use ISO C99 by default. In
most cases this won't matter, but there are some subtleties.

One of the ports that really requires the C standard to be set to gnu89,
is libiconv. The problem is that this port uses GNU-style inlining,
which is only enabled when building C89 code.

I propose the following patch:

--- converters/libiconv/Makefile
+++ converters/libiconv/Makefile
@@ -17,6 +17,7 @@
 
 USE_AUTOTOOLS=	libtool:15
 GNU_CONFIGURE=	yes
+USE_CSTD=	gnu89
 USE_GNOME=	gnometarget
 LIBTOOLFILES=	configure libcharset/configure
 CONFIGURE_ARGS=	--enable-static \

It shouldn't change the behaviour of the port when using GCC, but allows
us Clang folks to build libiconv out of the box. Erwin ran an
experimental ports build with Clang on pointyhat and according to
numbers, libiconv's failure caused it to skip compilation of 9600 other
ports...

Any comments?

-- 
 Ed Schouten <ed at 80386.nl>
 WWW: http://80386.nl/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-gnome/attachments/20090603/b3b2e9ea/attachment.pgp