console-kit-daemon leaking file descriptors?

[Jonathan Chen]

On Sat, Apr 18, 2009 at 10:59:32PM -0400, Joe Marcus Clarke wrote:
> On Sun, 2009-04-19 at 11:36 +1200, Jonathan Chen wrote:
> > On Sat, Apr 18, 2009 at 06:07:50PM -0400, Joe Marcus Clarke wrote:
> > > On Sun, 2009-04-19 at 08:44 +1200, Jonathan Chen wrote:
> > > > On Sat, Apr 18, 2009 at 02:42:57PM -0400, Joe Marcus Clarke wrote:
> > > > > On Sat, 2009-04-18 at 22:58 +1200, Jonathan Chen wrote:
> > > > > > Hi,
> > > > > > 
> > > > > > I'm running consolekit-0.3.0_6, and I'm seeing a file descriptor leak
> > > > > > on /dev/null. A "fstat -p pid" on console-kit-daemon on my
> > > > > > machine reveals that inode 7 (ie: /dev/null) has been opened with "r"
> > > > > > 1000+ times after a week or so of uptime.
> > > > > > 
> > > > > > Is anyone else seeing this?
> > > > > 
> > > > > No.  After a day and half of uptime, I have stdin, stdout, and stderr
> > > > > open to /dev/null, plus one additional /dev/null on FD 4.  If there was
> > > > > a linear leak, I should have /dev/null open over 100 times by now.  Can
> > > > > you reliably reproduce this leak on your system?
> > > > 
> > > > I've killed console-kit-daemon, and when it automatically restarts after
> > > > a gdm login, I see the output below. 36 read-opens on /dev/null so
> > > > far - which looks pretty suspicious. I'm running 7.1-STABLE FreeBSD
> > > > as of "Apr 3 08:10:13 NZDT 2009".
> > > 
> > > Does this patch fix the problem?
> > > 
> > > http://www.marcuscom.com/downloads/patch-src_ck-sysdeps-freebsd.c
> > 
> > Yes! Thanks heaps!
> 
> Then that means you have a deeper problem.  Most likely you do not have
> procfs mounted on /proc.  The console or /var/log/messages should have
> warnings.

Hmm. Yes it does. I wasn't aware that GNOME required procfs mounted.

Thanks for that.
-- 
Jonathan Chen <jonc at chen.org.nz>                    Once is dumb luck.
                                                 Twice is coincidence.
             Three times and Somebody Is Trying To Tell You Something.