Suggest: gdm_lang flag for gdm startup language

[Daichi GOTO]

Joe Marcus Clarke wrote:
> On Tue, 2009-04-14 at 14:24 +0900, Daichi GOTO wrote:
>> Joe Marcus Clarke wrote:
>>> On Tue, 2009-04-14 at 12:01 +0900, Daichi GOTO wrote:
>>>> Hi gnome guys,
>>>>
>>>> I want to suggest follow patch to /usr/local/etc/rc.d/gdm
>>>> RGng script setting default startup language. With follow
>>>> patch, someone want to use gdm as non-English default, e.g.,
>>>> adding gdm_lang="ja_JP.UTF-8" to /etc/rc.conf is anwser.
>>>>
>>>> It is bothering me every day first time I must set Japanese
>>>> when gdm login display. Do you have any ideas?  If you have
>>>> no objection, I want to commit to /usr/ports/x11/gdm/files/gdm.in
>>> We already have a procedure for this documented on the FAQ:
>>>
>>> http://www.freebsd.org/gnome/docs/faq2.html#q29
>>>
>>> The /etc/profile method is preferred as there is already support for it
>>> upstream.
>>>
>>> Joe
>> Yes, I know /etc/profile method, and I do not recognize that
>> is good idea for this issue. In fact, that is very bad idea
>> I guess. We should prevent /etc/profile method ASAP.
>>
>> Reasons:
>>
>>    1. /etc/profile affects others than gdm. FreeBSD console
>>       does not support non-English displaying. And some
>>       applications cannot been built without LANG=C. So, to
>>       set LANG=??? (e.g. ja-JP.UTF-8) on /etc/profile is
>>       very bad idea. The /etc/profile method affects to many
>>       phenomena.
>>
>>    2. I suggest controlling application behavior installed
>>       by Ports Collection in /etc/rc.conf is clear and simple
>>       way. Should we (especially for non-English user) edit
>>       /etc/rc.conf and /etc/profile every time updated relative
>>       components?  It is bothering matter.
>>
>> I'm thinking adding gdm_lang="ja_JP.UTF-8" to /etc/rc.conf
>> is very clear and easy understanding for common user of Gnome.
>> How do you make of it??
> 
> I admit I'm not the best person to evaluate i18n or l10n solutions.  I'm
> happy with en_US or even ASCII.  I think bland is going to look at
> restoring login cap support to GDM, but I when the freeze ends I'll look
> at committing your suggestion.
> 
> Joe

Oh, really? Thank you very much! :)

>>>> Thanks :)
>>>>
>>>>
>>>> --- gdm.orig	2009-04-14 11:55:01.000000000 +0900
>>>> +++ gdm	2009-04-14 11:54:36.000000000 +0900
>>>> @@ -15,6 +15,7 @@
>>>>
>>>>   gdm_enable=${gdm_enable-${gnome_enable}}
>>>>   gdm_preserve_base_pam_conf=${gdm_preserve_base_pam_conf-NO}
>>>> +gdm_lang=${gdm_lang-${LANG}}
>>>>
>>>>   export PATH=/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:/usr/local/sbin
>>>>
>>>> @@ -54,7 +55,7 @@
>>>>   	sleep 1
>>>>   	iter=$(expr ${iter} + 1)
>>>>       done
>>>> -    ${command} ${gdm_flags} ) &
>>>> +    LANG=${gdm_lang} ${command} ${gdm_flags} ) &
>>>>   }
>>>>
>>>>   load_rc_config ${name}


-- 
   Daichi GOTO, http://people.freebsd.org/~daichi