ports/124115: net/openldap24-server: Auto-Detect OpenLDAP version and modify knobs according to common names

Jens Rehsack rehsack at web.de
Sun Jun 22 15:52:23 UTC 2008


Hi,

I tried a little around with the submitted patch and detected 2 issues:
1) I had a typo in line 37 of bsd.ldap.mk
-DEFAULT_OPENLDPAP_VER?= 23
+DEFAULT_OPENLDAP_VER?= 23
It's quite easy to fix it ;)

2) A port (security/seahorse) checks in line 72 for ${WANT_OPENLDAP_VER},
    which is deprecated. By the way - it doesn't want to check for
    WANT_OPENLDAP_VER, it wants to check for ${OPENLDAP_VER}.
    Doing this would require to split the "code" in bsd.ldap.mk into a
    pre- and post-part, not handle everything in the post-part.

What do you think?

/Jens


More information about the freebsd-gnome mailing list