[PATCH] HAL is broken with real SCSI CD-ROM /CD-RW devices

[Joe Marcus Clarke]

On Sun, 2008-02-03 at 11:15 -0500, kabaev at gmail.com wrote:
> Hi,
> 
> this a reserve copy in case one poseted to mainling lists gets lost
> somehow. You seem to be the one doing majority of Gnome porting where
> CAM is involved these days, so I thought direct message is warranted.
> 
> --
> Alexander Kabaev
> 
> ==============================
> Hi,
> 
> hal port as it exists on today's ports CVS works very badly with my
> Plextor CD-RW, which hapens to be a generic SCSI-3/MMC2 device. Hal
> hangs the drive firmware and sometimes oven freezes the whole SCSI bus
> when probing for CDROM. It turns out that whoever did the initial hal
> port did not know that CDB length parameter passed to CAM is
> significant and just hardcoded it to 16. This causes 16 bytes of
> command to be DMA's to the drive even for SCSI 6 and 10 byte commands
> and that is not received warmly by at least some real SCSI targets.
> 
> Attached patch (also at
> http://people.freebsd.org/~kan/hal-patch-scsi.diff) fixes this to
> renaming unused timeout parameter in hfp_cdfrom_send_ccb function to be
> ccb_len and passing proper command length where necessary.

Thanks!  I've committed this upstream (into hal git) which means it will
make it into the upcoming GNOME 2.22 release.  I'll also push this into
our ports tree now.

Joe

-- 
PGP Key : http://www.marcuscom.com/pgp.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/freebsd-gnome/attachments/20080203/bf974068/attachment.pgp