HAL on FreeBSD 5.5 redux

[Joe Marcus Clarke]

On Fri, 2007-02-09 at 06:34 +0100, Michael Nottebrock wrote:
> While regression testing a few new patches for KDE's media kioslave, I found 
> out that the FreeBSD 5.5 fix for cdroms as committed to ports doesn't 
> actually work - because of this code:
> 
> /* Better to assert here than panic the machine. */
> /* XXX Should this be a conditional?  How likely is this? */
> assert(cdrom->channel >= 0);
> assert(cdrom->device >= 0 && cdrom->device < 2);

Which assertion is actually failing?  What are the values of
cdrom->channel and cdrom->device?  These assertions are to prevent a bad
value from being passed to the kernel thus resulting in a panic.  If
these assertions are being hit, then the probe should terminate on a
SIGABRT.

> 
> I don't know what this is supposed to do (avoid using both atapicam & atapicd 
> devices?), but it does prevent detection of any cdrom volumes here when 
> atapicam is disabled. I have two cd/dvd writers (acd0 and acd1) in this 
> machine. 
> 
> I didn't notice this earlier because I skipped hal-0.5.8-20061224, but I did 
> go back to it now and can confirm that that version doesn't work either 
> unless those lines are removed.

There was a recent change that went into HAL to favor atapicam
installations over those without.  I wonder if this could be causing
problems.  Please provide an lshal.

Joe

> 
> 
> Cheers,
-- 
PGP Key : http://www.marcuscom.com/pgp.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/freebsd-gnome/attachments/20070209/d2a15bd0/attachment.pgp