seeking approval for x11-toolkits/vte ports -- small changes

Alexey Dokuchaev danfe at FreeBSD.org
Thu Mar 16 20:07:23 UTC 2006


hi there,

what do you guy think of attached patch?

commit log:

- Convert to OPTIONS
- Adjust text slightly so it fits in dialog
- DRI -> DRI/GLX since nVidia GLX does not use DRI
- Style nit: s/ifdef/if defined/ in Makefile
- Kill EOL space in pkg-descr, americanize 
-------------- next part --------------
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/x11-toolkits/vte/Makefile,v
retrieving revision 1.53
diff -u -r1.53 Makefile
--- Makefile	15 Mar 2006 05:51:26 -0000	1.53
+++ Makefile	16 Mar 2006 20:04:27 -0000
@@ -27,15 +27,13 @@
 		BSD_PTHREAD_LIBS="${PTHREAD_LIBS}"
 CONFIGURE_ARGS=	--disable-python
 
-.ifdef(WITH_GLX)
+OPTIONS=	GLX	"Enable support for DRI/GLX rendering" off
+
+.include <bsd.port.pre.mk>
+
+.if defined(WITH_GLX)
 CONFIGURE_ARGS+=	--with-glX
 USE_GL=			yes
 .endif
 
-pre-everything::
-	@${ECHO_MSG} ""
-	@${ECHO_MSG} "Vte supports the following configurable option(s):"
-	@${ECHO_MSG} "	WITH_GLX=yes	Enable support for DRI rendering (may improve performance)"
-	@${ECHO_MSG} ""
-
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>
Index: pkg-descr
===================================================================
RCS file: /home/pcvs/ports/x11-toolkits/vte/pkg-descr,v
retrieving revision 1.1
diff -u -r1.1 pkg-descr
--- pkg-descr	6 Oct 2002 01:49:09 -0000	1.1
+++ pkg-descr	16 Mar 2006 20:04:27 -0000
@@ -1,2 +1,2 @@
-Terminal widget with improved font, internationalisation and accessibility 
+Terminal widget with improved font, internationalization and accessibility
 support for the GNOME 2 desktop.  Designed to replace libzvt.


More information about the freebsd-gnome mailing list