WITHOUT_DEBUG flag for x11-toolkits/gtk20
Jeremy Messenger
mezz7 at cox.net
Mon Feb 20 10:22:09 PST 2006
On Mon, 20 Feb 2006 11:36:34 -0600, Jeremy Messenger <mezz7 at cox.net> wrote:
> On Mon, 20 Feb 2006 08:44:14 -0600, Babak Farrokhi <babak at farrokhi.net>
> wrote:
>
>> Folks,
>>
>> I have always been wondering why this port does not support standard
>> WITHOUT_DEBUG flag (as many ports support this flag, and once you set
>> WITH_DEBUG=no in /etc/make.conf, those ports while enable debugging
>> instead!). So I just added this simple modification to the Makefile to
>> honor
>> the WITHOUT_DEBUG knob. (I am not sure, maybe there was a good reason
>> for
>> using WITH_DEBUG instead of WITHOUT_DEBUG).
>>
>> --- gtk20.patch begins here ---
>> diff -ruN gtk20.orig/Makefile gtk20/Makefile
>> --- gtk20.orig/Makefile Mon Feb 20 17:48:23 2006
>> +++ gtk20/Makefile Mon Feb 20 17:52:25 2006
>> @@ -51,6 +51,11 @@
>> # on the command-line.
>> # Set to minimum if you want to send in a backtrace; set # to yes if
>> you
>> want to know what gtk thinks it's doing.
>> +.if defined(WITHOUT_DEBUG)
>> +.if ${WITHOUT_DEBUG:L} == "yes"
>> +WITH_DEBUG= no
>> +.endif
>> +.endif
>> .if defined(WITH_DEBUG)
>> .if ${WITH_DEBUG:L} == "no"
>> CONFIGURE_ARGS+= --enable-debug=no
>> --- gtk20.patch ends here ---
>>
>>
>> Any opinions?
>
> Making sense for add WITHOUT_DEBUG, but how about this patch?
>
> http://people.freebsd.org/~mezz/diff/gtk20.diff
It has been committed, thanks for submitted!
Cheers,
Mezz
> Cheers,
> Mezz
>
>> --
>> Babak Farrokhi
>> babak at farrokhi.net
--
mezz7 at cox.net - mezz at FreeBSD.org
FreeBSD GNOME Team
http://www.FreeBSD.org/gnome/ - gnome at FreeBSD.org
More information about the freebsd-gnome
mailing list