ports/78918: Firefox does not build with freetype2-2.1.9

[Peter.Weiss at ConSol.de]

The following reply was made to PR ports/78918; it has been noted by GNATS.

From: Peter.Weiss at ConSol.de
To: Michael Johnson <ahze at FreeBSD.org>
Cc: gnome at FreeBSD.org, freebsd-gnats-submit at FreeBSD.org
Subject: Re: ports/78918: Firefox does not build with freetype2-2.1.9
Date: Fri, 18 Mar 2005 07:14:24 +0100

 Michael Johnson <ahze at FreeBSD.org> writes:
 
 > Synopsis: Firefox does not build with freetype2-2.1.9
 >
 > State-Changed-From-To: open->closed 
 > State-Changed-By: ahze
 > State-Changed-When: Wed Mar 16 21:13:41 GMT 2005
 > State-Changed-Why: 
 > Please make sure your ports tree (www/firefox) is up to date. Looks like you 
 > may be missing www/firefox/files/patch-bugzilla149334
 >
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=78918
 
 
 Hi,
 
 my patch-bugzilla149334 is of latest revision:
 
 /usr/ports/www/firefox/files:1> cvs stat patch-bugzilla149334 
 ===================================================================
 File: patch-bugzilla149334      Status: Up-to-date
 
    Working revision:    1.1     Thu Mar 10 00:43:22 2005
    Repository revision: 1.1     /export/cvs/ports/www/firefox/files/patch-bugzilla149334,v
    Sticky Tag:          (none)
    Sticky Date:         (none)
    Sticky Options:      (none)
 
 /usr/ports/www/firefox/files:1> md5sum patch-bugzilla149334 
 1aef0c52cf1902d24a3e2d6c6a37e6ba  patch-bugzilla149334
 
 /usr/ports/www/firefox:1> make extract
 ===>  Vulnerability check disabled, database not found
 ===>  Found saved configuration for firefox-1.0_7,1
 ===>  Extracting for firefox-1.0.1_3,1
 => Checksum OK for firefox-1.0.1-source.tar.bz2.
 ===>   firefox-1.0.1_3,1 depends on file: /usr/local/bin/perl5.8.6 - found
 
 Extracting source (this takes a while) ...
 
 /usr/ports/www/firefox:1> make patch
 ===>  Patching for firefox-1.0.1_3,1
 ===>   firefox-1.0.1_3,1 depends on file: /usr/local/bin/perl5.8.6 - found
 ===>  Applying FreeBSD patches for firefox-1.0.1_3,1
 /usr/ports/www/firefox:1> echo $?
 0
 
 But firefox still fails to build.  Of course I did a make clean, cvs
 update and all that...
 
 If I look into the patch it patches nsFreeTypeFont.cpp to use the member face_id
 of class FTC_ImageTypeRec which the compiler complains about:
 
 @@ -177,7 +177,7 @@ nsFreeTypeFont::getFTFace()
    FTC_Manager mgr;
    nsresult rv;
    mFt2->GetFTCacheManager(&mgr);
 -  rv = mFt2->ManagerLookupSize(mgr, &mImageDesc.font, &face, nsnull);
 +  rv = mFt2->ManagerLookupFace(mgr, mImageDesc->face_id, &face);
    NS_ASSERTION(NS_SUCCEEDED(rv), "failed to get face/size");
 
 Peter
 
 -- 
 Peter.Weiss at consol.de                         ConSol* Software GmbH
 Phone  +49 89 45841-100                       Consulting & Solutions
 Mobile +49 177 6040121                        Franziskanerstr. 38
 http://www.consol.de                          D-81669 München