ports/75816: [PATCH] www/firefox: new mozilla.sh and package
script
Jose M Rodriguez
josemi at freebsd.jazztel.es
Fri Feb 25 09:00:57 GMT 2005
El Viernes, 25 de Febrero de 2005 08:56, Joe Marcus Clarke escribió:
> Synopsis: [PATCH] www/firefox: new mozilla.sh and package script
>
> State-Changed-From-To: open->closed
> State-Changed-By: marcus
> State-Changed-When: Fri Feb 25 07:52:11 GMT 2005
> State-Changed-Why:
> I've committed some of this. What I didn't commit was the PIS work.
> While the framework might be there to embed RC scripts into Mozilla
> and Firefox, I don't think this is the right place to add sound
> server support. I don't want to get bogged down in a lot of local
> scripts that make these ports unsupportable, or in violation of our
> license agreement with Mozilla.
>
Please, consider the cleanhome moz_pis for firefox. This makes firefox
upgrades don't be hurt by local profile.
> As for your pkg-[de]install work, I didn't see a real advantage of
> moving some of these things out into scripts. Plus, it looks like
> your pkg-deinstall would nuke all of browser_plugins.
>
Only make this happens from packages, not only from ports. As an
example, you get the java plugin working when you install the
firefox/mozilla package. I'll investigate the pkg-deinstall.
> The rest of patches looked okay, and were merged. In the future,
> please do all diffs frome one level above the directory in question.
> For example:
>
> diff -ruN firefox.orig firefox
>
> This makes patching much easier. Also, please don't submit diffs
> against CVS versions. If a new version hasn't been released, either
> wait, or submit the diff against the current version in the ports
> tree. Thanks.
>
--
josemi
> http://www.freebsd.org/cgi/query-pr.cgi?pr=75816
More information about the freebsd-gnome
mailing list