ports/www/firefox/Makefile,v 1.92 2004/09/28 bug(s)

[Clemens Fischer]

hi.

had the following problem:  five of the files comprising "firefox" lack an
include file.

symptom:

,----
| In file included from /usr/X11R6/include/X11/Xft/Xft.h:35,
|                  from nsDeviceContextGTK.cpp:78:
| /usr/local/include/freetype2/freetype/freetype.h:20: #error "`ft2build.h' hasn't been included yet!"
| /usr/local/include/freetype2/freetype/freetype.h:21: #error "Please always use macros to include FreeType header files."
| /usr/local/include/freetype2/freetype/freetype.h:22: #error "Example:"
| /usr/local/include/freetype2/freetype/freetype.h:23: #error "  #include <ft2build.h>"
| /usr/local/include/freetype2/freetype/freetype.h:24: #error "  #include FT_FREETYPE_H"
| nsDeviceContextGTK.cpp: In function `void xlfd_from_pango_font_description(GtkWidget *, const PangoFontDescription *, nsStr
| ing &)':
| nsDeviceContextGTK.cpp:1119: warning: unused variable `char * tmp'
| gmake[4]: *** [nsDeviceContextGTK.o] Error 1
| gmake[4]: Leaving directory `/usr/ports/www/firefox/work/mozilla/gfx/src/gtk'
| gmake[3]: *** [libs] Error 2
| gmake[3]: Leaving directory `/usr/ports/www/firefox/work/mozilla/gfx/src'
| gmake[2]: *** [libs] Error 2
| gmake[2]: Leaving directory `/usr/ports/www/firefox/work/mozilla/gfx'
| gmake[1]: *** [tier_9] Error 2
| gmake[1]: Leaving directory `/usr/ports/www/firefox/work/mozilla'
| gmake: *** [default] Error 2
| *** Error code 2
`----

fix(?):  put the required "#include..." near the top of those files.  those
files are:

work/mozilla/gfx/src/gtk/nsDeviceContextGTK.cpp:// -ino: 20041002-1655
work/mozilla/gfx/src/gtk/nsDrawingSurfaceGTK.cpp:// -ino: 20041002-1702
work/mozilla/gfx/src/gtk/nsFontMetricsUtils.cpp:// -ino: 20041002-1655
work/mozilla/gfx/src/gtk/nsFontMetricsXft.cpp:// -ino: 20041002-1655
work/mozilla/gfx/src/gtk/nsGfxFactoryGTK.cpp:// -ino: 20041002-1708

what i did:

,----
|  1512  041002-16:18 localname=$(pwd) && portupgrade -Wv ${localname#*/ports/}
|  1513  041002-16:52 find . -name 'nsDeviceContextGTK.cpp'
|  1514  041002-16:53 vi `find . -name 'nsDeviceContextGTK.cpp'`
|  1515  041002-16:56 hi
|  1516  041002-16:56 note '' Readme
|  1517  041002-16:57 make BATCH=YES
|  1518  041002-17:00 find . -name 'nsDrawingSurfaceGTK.cpp'
|  1519  041002-17:01 vi `find . -name 'nsDrawingSurfaceGTK.cpp'`
|  1520  041002-17:02 make BATCH=YES
|  1521  041002-17:07 vi `find . -name 'nsGfxFactoryGTK.cpp'`
|  1522  041002-17:09 tv
|  1523  041002-17:09 make BATCH=YES
|  1524  041002-17:12 #rm /ports/distfiles/firefox-0.9.*
|  1525  041002-17:13 vi `find . -name 'nsFontMetricsUtils.cpp'`
|  1526  041002-17:14 m Readme
|  1527  041002-17:14 fg
|  1528  041002-17:14 tv
|  1529  041002-17:15 make BATCH=YES
|  1530  041002-17:17 vi `find . -name 'nsFontMetricsUtils.cpp'`
|  1531  041002-17:18 make BATCH=YES
|  1532  041002-17:21 vi `find . -name 'nsFontMetricsXft.cpp'`
|  1533  041002-17:21 make BATCH=YES
|  1534  041002-18:41 make BATCH=YES {d,r}einstall
|  1535  041002-18:48 hi 55
|  1536  041002-18:51 note '' Readme
|  1537  041002-18:53 g -r '^// -ino:' *
|  1538  041002-18:58 make clean;hi 33
`----

shouldn't there be a "central" include file higher up in the hierarchy where
to place that missing ``#include "ft2build.h"''?  or is my setup busted or
does everybody else install a firefox-package?

regards,

  clemens