libxklavier and upcoming xorg 6.8.1 upgrade

[Joe Marcus Clarke]

On Sun, 2004-11-28 at 20:25 -0500, Michael Johnson wrote:
> On Nov 28, 2004, at 8:20 PM, Michael Johnson wrote:
> 
> >
> > On Nov 28, 2004, at 8:15 PM, Michael Johnson wrote:
> >
> >>> Having no imake, this part fails and configure then checks if it 
> >>> needs
> >>> additional flags for X. It already has -I${X11BASE}/include in 
> >>> CPPFLAGS and
> >>> -L${X11BASE}/lib in LDFLAGS in environment, so it concludes that it 
> >>> doesn't
> >>> need any and sets both $x_includes and $x_libraries to empty 
> >>> strings. That
> >>> would be otherwise fine and the thing would bild. Unfortunately, it 
> >>> uses the
> >>> value of $x_libraries to construct location of xkb specifications 
> >>> without
> >>> further checks, and there it fails.
> >>> So for the solution: adding either 
> >>> "--with-xkb-base=${X11BASE}/lib/X11/xkb" or
> >>> "--x-includes=${X11BASE}/include --x-libraries=${X11BASE}/lib" to
> >>> CONFIGURE_ARGS in ports Makefile should solve the problem.
> >>
> >> This brings up a good point, the lines in bsd.port.mk
> >>
> >> .if defined(USE_XLIB)
> >> LIB_DEPENDS+=   X11.6:${X_LIBRARIES_PORT}
> >> # Add explicit X options to avoid problems with false positives in 
> >> configure
> >> .if defined(GNU_CONFIGURE)
> >> CONFIGURE_ARGS+=--x-libraries=${X11BASE}/lib 
> >> --x-includes=${X11BASE}/include
> >> .endif
> >> .endif
> >>
> >> Don't work with WITH_LIBTOOL_ since GNU_CONFIGURE is defined from 
> >> bsd.autotools.mk
> >> should the previous not be a part of bsd.autotools.mk?
> >
> > Or moved in bsd.port.mk so it works with bsd.autotools.mk ?
> 
> Like http://ahze.net/~ahze/bsd.port.mk.patch seems to work

Yeah, this looks okay.  I wonder if Kris can add this to pointyhat as
part of the X.Org 6.8.1 build.  If not, this should be turned into a PR
for future testing.

Joe

-- 
PGP Key : http://www.marcuscom.com/pgp.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/freebsd-gnome/attachments/20041128/6f783a1e/attachment.bin