About firefox new layout

[Jose M Rodriguez]

El Miércoles, 17 de Noviembre de 2004 12:39, Michael Johnson escribió:
> On Nov 17, 2004, at 5:58 AM, Jose M Rodriguez wrote:
> > El Miércoles, 17 de Noviembre de 2004 10:52, Michael Johnson 
escribió:
> >> On Nov 17, 2004, at 3:47 AM, Jose M Rodriguez wrote:
> >>> El Miércoles, 17 de Noviembre de 2004 05:52, Joe Marcus Clarke
> >>>
> >>> escribió:
> >>>> Jose M Rodriguez wrote:
> >>
> >> ---- snip ----
> >> [...]
> >>
> >>>> | This must be not only easier, but also safer.
> >>
> >> how is this easier and safer?
> >
> > The most common way to install firefox is with firefox[-config] and
> > run-mozilla.sh in the same dir.  This is the most proven layout
> > from the mozilla comunity.
>
> The default firefox install installs firefox in bin/firefox

well, This is the build deafult, but is more common see this as in 
mozilla (in firefox/mozilla/thunderbird in different unix variants).

In fact, this is the first test, see if there is an executable 
run-mozilla.sh in the same dir as "$0".

> [...]
> >
> > So we have our FreeBSD related stuff in ${PREFIX}/bin/firefox and
> > the mainstream mozilla stuff (without patches) in
> > ${PREFIX}/lib/firefox/firefox
>
> This shouldn't matter because before the last commit bin/firefox was
> linked to lib/firefox/lib/firefox-VERSION/bin/firefox
>

This isn't needed. It's more confortable to maintain

> >>> - install firefox[-config] under ${PREFIX}/lib/firefox
> >>
> >> Why install firefox[-config] in PREFIX/lib/firefox?
> >> I don't see any reason to do this. It's not like we have
> >> www/firefox-devel or anything
> >> that would conflict.
> >
> > Please, read above and see how ${PREFIX}/bin/mozilla and
> > ${PREFIX}/lib/mozilla/mozilla work in the same way.
>
> The major difference is bin/mozilla script has mail knobs
> and firefox doesn't do mail.

At last here:
mozilla script have 33 lines and a clean design
firefox script have 264 lines and more complexity

>
> >>> - install a brand new ${FILESDIR}/firefox.sh as
> >>> ${PREFIX}/bin/firefox
> >>
> >> So basically the only thing you want is when you open 2 sessions
> >> of firefox the
> >> 2nd session doesn't open but opens a new tab?
> >
> > Not really.  This may be taken with or without script split.
> >
> > I can send-pr to what is prefer:
> > - more patching to patch-browser_app_mozilla.in
> > - script split.
>
> I still don't understand why it's important to install firefox in
> lib/firefox
> and why we can't just edit  patch-browser_app_mozilla.in ?

This is not really the case.

We are talking about split the actual /usr/X11R6/bin/firefox script in 
two.

One /usr/X11R6/bin/firefox and one /usr/X11R6/lib/firefox/firefox.

/usr/X11R6/lib/firefox/firefox may be directly inherit from mozilla.  We 
use it only in first launchs of firefox.  And we don't have to maintain 
a local patch in the case mozilla change his script (less maintain 
effort).

/usr/X11R6/bin/firefox must be installed from ${FILESDIR}.  Or even use 
an external one and run-depends on it.

We can do here just what the FreeBSD project need and the use of the 
remote protocol, without seen the real complexity of a mozilla-app 
launch.

>
> Can you please explain why this is important, I still don't
> understand why
> installing firefox, firefox-config in lib/firefox is so important, or
> why it matters?
>

We can install firefox-config in any place.  But it's in most cases 
installed in the same dir as firefox

We can install firefox in any place.  But if we go install a distro 
specific script under ${PREFIX}/bin/ with the same name, 
${PREFIX}/lib/firefox/ seems a good candidate.

Also, if fiefox and run-mozilla.sh don't live in the same dir, you need 
joe patch-browser_app_mozilla.in

> > Also, if we go to script split, this must reach thunderbird also.
>
> Why?
>

Use the same method in all mozilla apps.  A distro specific script 
linking to a mozilla distributed script through sh exec.

But I think this can go even far.  If nobody seems any major objection 
to the script split concept,  A more coordinate operation may be 
reachable.

But this may require time.  Please, put this in quarantine.

--
  josemi
> >> Michael
> >
> > --
> >   josemi