games/gcompris* update

[Joe Marcus Clarke]

On Thu, 2004-03-04 at 14:18, John Hay wrote:
> > >
> > >I haven't seen this, but then I didn't try --without-python because there 
> > >were already so many things that requires python. I'll have a look at it 
> > >over the weekend though. Was there a reason that you wanted it without 
> > >python? From what I understand there isn't anything in gcompris using it 
> > >yet, they just added the framework for it, so that boards can be written 
> > >in python.
> > >
> > Right. But afair my very first attempt to update gcompriss was 4.9 
> > (gcompriss release) and that time gcompriss failed to build w/ python 
> > support. Since I don't like snakes for some reason I switched  their 
> > support off. But built w/o python support gcompriss complained at 
> > run-time about missed pyton module plus I got few abort()s related to 
> > python integration randomly walking through the game boards while 
> > testing. All this give me impression that port is not safe for parents 
> > yet ;-)
> >    To be honest I did not try 5.0-2 versions with python support. May 
> > be something changed since 4.9 time and you will be more lucky. Let me know.
> 
> Ok, I probably didn't look hard enough previously because this time I
> did see the python complaints when it was compiled without python. I
> started with your patch and made it use python and a few other small
> tweaks and it seems to be working now. I have patch against your patch
> at the end of the email. A patch agains cvs is available at:
> 
> http://people.freebsd.org/~jhay/gcompriss2.patch-jhay
> 
> Any comments? The sound also works and my kids love it, but using it
> on a 300MHz Celeron is pushing it a bit.

It looks like you've done a good job.  The only thing I see is that you
need to use a tab instead of spaces on line 26 of the Makefile between
the variable name and value.  bland should probably have the final say,
though.

Joe

> 
> John
-- 
PGP Key : http://www.marcuscom.com/pgp.asc


-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/freebsd-gnome/attachments/20040304/76d55b3e/attachment.bin