Need feedback/review, a big change in AbiWord2 port.

[Joe Marcus Clarke]

On Tue, 2004-06-08 at 22:01, Jeremy Messenger wrote:
> On Tue, 8 Jun 2004 20:38:11 -0400, Adam Weinberger <adamw at FreeBSD.org>  
> wrote:
> 
> >>> (06.08.2004 @ 1513 PST): Jeremy Messenger said, in 3.8K: <<
> >> >>>>	- Change the default spell from Enchant to Aspell, because it  
> >> doesn't
> >> >>>>	  work at all unless you compile Enchant with the Aspell support. I
> >> >>>>	  think, it's waste to depend on Enchant by default.
> >> >>>>
> >> >>>>	  Also, I have removed the check of Enchant. I prefer to see force
> >> >>>>	  user to want use Enchant if they know what to do with it. I need
> >> >>>>	  the
> >> >>>>	  help on write the better comment in @${ECHO_CMD} about this.
> >> >>>
> >> >>>I disagree strongly with this. I think that Enchant is a great idea.
> >> >>>Enchant isn't being utilized properly ATM, but it has the propensity  
> >> to
> >> >>>be a great leap forward in i18n spell-checking.
> >> >>
> >> >>What's your best suggest then? Force Enchant to compile with Aspell
> >> >>support? This is the way that I will allow Enchant to be default. It
> >> >>doesn't make any sense to have something that will not work by  
> >> default.
> >> >>I
> >> >>think, it's important to have the default that is just work.
> >> >
> >> >Enchant should theoretically work fine without aspell support. But, I
> >> >think that Enchant should be enabled by defaultm, and should work
> >> >out-of-the-box, by whatever means necessary.
> >>
> >> Do you mean, you think we should change Enchant port to compile with
> >> Aspell support? If no, then I will not switch Aspell to Enchant for the
> >> default spell, unless you have anything to fix it.
> >>> end of "Re: Need feedback/review, a big change in AbiWord2 port." from  
> >>> Jeremy Messenger <<
> >
> > Yes. If Enchant needs aspell support for AbiWord2 to work best, then
> > Enchant should depend upon aspell by default.
> 
> With those diffs, now the spell works by default with Enchant. No object  
> tonight and I will commit those by tomorrow. Thanks for review/feedback,  
> marcus and adamw!
> 
> http://people.freebsd.org/~mezz/diff/enchant.diff
> http://people.freebsd.org/~mezz/diff/AbiWord2.diff

These look fine.  Thanks!

Joe

> 
> Cheers,
> Mezz
> 
> > # Adam
> >
> >
> > --
> > Adam Weinberger
> > adamw at magnesium.net || adamw at FreeBSD.org
> > adamw at vectors.cx    ||   adamw at gnome.org
> > http://www.vectors.cx
-- 
PGP Key : http://www.marcuscom.com/pgp.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/freebsd-gnome/attachments/20040608/96a94c86/attachment.bin