graphics/sodipodi (0.32) build has been failed..

[Franz Klammer]

On Fri, 2003-06-20 at 21:26, Jeremy Messenger wrote:
> Kill the M2 client's mime type.. Sorry for spam..
> 

you are not the only one who had this problem in the
last time. i'm also :-)

> ------patch-src::helper::action.c------
> --- src/helper/action.c.orig	Fri Jun 20 15:59:10 2003
> +++ src/helper/action.c	Fri Jun 20 16:05:30 2003
> @@ -12,7 +12,9 @@
>   */
>  #include <string.h>
> +#ifdef HAVE_MALLOC_H
>  #include <malloc.h>
> +#endif
>  #include <libnr/nr-macros.h>
>  ------patch-src::helper::action.c------
> 

i have a limited knowledge in C but i'm not sure that this
ist the right way. wouldn't it be better that you change
the #inlcude <malloc.h> to #include <stdlib.h>?
i think there must be a reason why this file is included 
even if the port build with out malloc.h.

many other ports do it in this way. here an example from
mozilla/Makefile:

@${FIND} ${WRKSRC}/other-licenses/libical -name "*.c" | ${XARGS} \
        ${REINPLACE_CMD} 's|<malloc.h>|<stdlib.h>|g'

franz.

> On Fri, 20 Jun 2003 16:22:02 -0500, Jeremy Messenger <mezz7 at cox.net> wrote:
> 
> > Try it again, but add cc to Joe and me so we can get an attach.
> >
> > Cheers,
> > Mezz
> >
> > On Fri, 20 Jun 2003 16:19:26 -0500, Jeremy Messenger <mezz7 at cox.net> 
> > wrote:
> >
> >> Err, it seems like the maillist removed the patch.. Let's try it 
> >> again...
> >>
> >> On Fri, 20 Jun 2003 16:16:17 -0500, Jeremy Messenger <mezz7 at cox.net> 
> >> wrote:
> >>
> >>> It has been failed, because of the malloc.h issue like this:
> >>>
> >>> =========================
> >>> In file included from action.c:15:
> >>> /usr/include/malloc.h:3:2: #error "<malloc.h> has been replaced by 
> >>> <stdlib.h>"
> >>> gmake[3]: *** [action.o] Error 1
> >>> gmake[3]: Leaving directory 
> >>> `/usr/ports/graphics/sodipodi/work/sodipodi-0.32/src/helper'
> >>> gmake[2]: *** [all-recursive] Error 1
> >>> =========================
> >>>
> >>> Here's an attach to get it fixes. I learned it from the different 
> >>> patch, so hope I am doing it correct; it just built fine. :-)
> >>>
> >>> Cheers,
> >>> Mezz
-- 
WEBONAUT.com
http://webonaut.com
mailto:klammer at webonaut.com