bin/165789: bsdlabel(8): partition c doesn't cover the whole unit!

[Bengt Ahlgren]

"Andrey V. Elsukov" <ae at FreeBSD.org> writes:

> On 06.04.2012 2:10, Bengt Ahlgren wrote:
>>  bsdlabel: partition c doesn't cover the whole unit!
>>  bsdlabel: An incorrect partition c may cause problems for standard system utilities
>>  
>>  I added a printout of the value bsdlabel compares with:
>>  
>>  bsdlabel: partition c doesn't cover the whole unit! 1953525168
>>  
>>  This number corresponds to the size of the whole disk, not the size of
>>  the slice, so lp->d_secperunit is not the right variable to use, or is
>>  incorrectly set.
>>  
>>  Finally, I stepped back to r220455 (in stable/8).  That version of
>>  bsdlabel did not complain, so it seems that r227564 by ae (cc:d) is
>>  causing, or making visible, this problem.
>
> Hi,
>
> Thank you for your report. Yes, r227564 has made visible a known sysinstall's bug.
> GEOM_PART_BSD already has quirk that automatically fixes it, can you try attached patch?

The patch does fix the issue with bsdlabel - thanks!

I am however curious to why you refer to a sysinstall bug.  I did not
use sysinstall to create the partitions.

Bengt