HEADS UP: device name checking on device registration

Kostik Belousov kostikbel at gmail.com
Wed Oct 13 15:09:57 UTC 2010


On Wed, Oct 13, 2010 at 11:50:26AM +0300, Jaakko Heinonen wrote:
> 
> [Posting a patch to -geom for comments.]
> 
> On 2010-10-07, Jaakko Heinonen wrote:
> > Currently several GEOM classes (notably geom_label) allow to create
> > devices with invalid names. Below is a link to a patch which converts
> > g_dev_taste() to use make_dev_p() with MAKEDEV_CHECKNAME flag. It's not
> > a complete solution and essentially changes the panic to a printf.
> 
> What do you think about this patch?
> 
> 	http://people.freebsd.org/~jh/patches/geom_dev-checkname.2.diff
> 
> Any better ideas how to handle this in GEOM? It doesn't seem to be
> trivial to propagate an error from g_dev_taste() due to asynchronous
> nature of the device registration in GEOM.

You might consider creating some well-controlled name instead of failed
one, and printing a diagnostic describing what happen.
/dev/reservation/<serial number>
could be an example, also demonstrating my lack of imagination.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-geom/attachments/20101013/6b4b8300/attachment.pgp


More information about the freebsd-geom mailing list