svn commit: r193112 - head/etc/rc.d

[Pawel Jakub Dawidek]

On Sun, May 31, 2009 at 11:46:39PM +0400, Dmitry Morozovsky wrote:
> On Sun, 31 May 2009, Doug Barton wrote:
> 
> DB> Dmitry Morozovsky wrote:
> DB> > Doug,
> DB> > 
> DB> > On Sat, 30 May 2009, Doug Barton wrote:
> DB> > 
> DB> > DB> Author: dougb
> DB> > DB> Date: Sat May 30 19:38:51 2009
> DB> > DB> New Revision: 193112
> DB> > DB> URL: http://svn.freebsd.org/changeset/base/193112
> DB> > DB> 
> DB> > DB> Log:
> DB> > DB>   As previously advertised, remove this script prior to the 8.0 branch.
> DB> > 
> DB> > Was there an agreement what should one do with dumping to gmirror (see 
> DB> > sbin/geom/class/mirror/gmirror.8) ?
> DB> 
> DB> I'm not familiar with that issue, but it sounds like something that
> DB> needs its own rc.d script. If someone who knows what is supposed to
> DB> happen wants to write something up and send it to the freebsd-rc@ list
> DB> I'll be glad to help review it.
> 
> Something like (checks should be added, yeah)
> 
> #!/bin/sh
> #
> # $FreeBSD$
> #
> 
> # BEFORE: savecore
> # PROVIDE: gmirror-savecore
> # KEYWORD: nojail
> 
> . /etc/rc.subr
> 
> name="gmirror_savecore"
> start_cmd="gmsavecore_start"
> stop_cmd=":"
> 
> gmsavecore_start()
> {
>         gmirror configure -b prefer /dev/dumpdev
> }
> 
> load_rc_config $name
> run_rc_command "$1"
> 
> possibly?

It's not that simple...

First you have to remember previous balance algorithm and recover it
once dumping crash dump is done.

You also have to check if dumpdev is placed somewhere on a gmirror
provider, which is not that simple, unfortunately.

Imagine your dump partition is called /dev/label/dump and there is a
long way to gmirror provider:

	label/dump -> mirror/root0s1b -> mirror/root0s1 -> mirror/root0

You can't just call 'gmirror configure -b prefer /dev/label/dump'.

I'm happy to review another patch, but I don't really have any bright
idea of how this should be implemented:)

-- 
Pawel Jakub Dawidek                       http://www.wheel.pl
pjd at FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-geom/attachments/20090601/053d74a3/attachment.pgp