glabel for ufs: size check is overzealous?

[Ivan Voras]

Andriy Gapon wrote:
> on 21/04/2009 19:18 Ivan Voras said the following:
>> Andriy Gapon wrote:
>>> glabel insists that for UFS2 the following must hold true:
>>> pp->mediasize / fs->fs_fsize == fs->fs_size
>>>
>>> But in reality it doesn't have to be this way, there can be valid reasons to make
>>> filesystem smaller than available raw media size.
>>>
>>> I understand that this is a good sanity check, but maybe there are other ways to
>>> extra-check that we see a proper superblock, without imposing the limitation in
>>> question.
>> Shouldn't fsck complain of this inconsistency?
> 
> I don't see why it should and - no, it actually does not.
> fsck checks only filesystem's internal consistency, it doesn't check media size, etc.

Well yes, if the number of blocks is really incorrect it should be
visible from the arrangement of the metadata but still - that makes the
field almost useless doesn't it?

>		    pp->mediasize / fs->fs_fsize >= fs->fs_size) {

Looks like it cannot harm anything.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 258 bytes
Desc: OpenPGP digital signature
Url : http://lists.freebsd.org/pipermail/freebsd-geom/attachments/20090421/d9f321b4/signature.pgp